Add new MAX_PROJECT_VISIBILITY config option
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
max-project-visibility
branch
2 times, most recently
from
e821c3e
to
e9e6edf
Compare
josephsnyder
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@williamjallen, most things look good in terms of project creation. I can see the dropdown change for a user as I update the .env file.
When it comes to editing a project though, the visibility selector isn't pared down like it is as the time of creation:
When creating:
When editing:
It still properly 403s with the right message if a bad choice is selected, but I would rather they not have the choice.
williamjallen
force-pushed
the
max-project-visibility
branch
from
e9e6edf
to
2df0100
Compare
josephsnyder
approved these changes
Apr 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
This builds on top of the work done in #2115, and adds a new `REQUIRE_AUTHENTICATED_SUBMISSIONS` configuration option which requires regular users to enable authenticated submissions when creating or editing projects. Instance administrators are able to override this setting. This should be merged after #2115.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CDash administrators may want users to be able to create projects on their own, but not public or protected projects. This PR adds a new
MAX_PROJECT_VISIBILITYenvironment variable which specifies the most visible setting a project can be configured to use. Instance administrators can override this setting, to allow some projects to be made public or protected with administrator approval.