Use APP_KEY to authenticate API requests from remote workers #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in
/CDash/app/cdash/tests/kwtest/simpletest/mock_objects.php on line 732
zackgalbreath
force-pushed
the
remote_workers_auth
branch
from
69a38cc
to
d56816b
Compare
zackgalbreath
force-pushed
the
remote_workers_auth
branch
from
d56816b
to
334449f
Compare
zackgalbreath
force-pushed
the
remote_workers_auth
branch
2 times, most recently
from
e5db166
to
6887f97
Compare
williamjallen
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Instead of passing around the app key, I think it would be better to use Laravel's encrypt() and decrypt() helpers. There isn't necessarily anything wrong with the current setup, but it feels like a bad idea to have any code paths which export the app key directly.
zackgalbreath
force-pushed
the
remote_workers_auth
branch
from
6887f97
to
3613eda
Compare
williamjallen
requested changes
Apr 13, 2024
There was a problem hiding this comment.
The files in question are due for a refactor at some point, but that can be done at a future point. While doing that, I think it would make sense to create a special middleware group for inter-node communication routes like these where the routes are only accessible internally.
zackgalbreath
force-pushed
the
remote_workers_auth
branch
2 times, most recently
from
ec520ce
to
98c814b
Compare
zackgalbreath
force-pushed
the
remote_workers_auth
branch
from
98c814b
to
cd0850a
Compare
williamjallen
approved these changes
Apr 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zackgalbreath
added a commit
that referenced
this pull request
Apr 22, 2024
Use an internal, secured API endpoint to store files parsed from Upload.xml when CDash is configured to use remote workers. Follow-up to #2143
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
Use an internal, secured API endpoint to store files parsed from Upload.xml when CDash is configured to use remote workers. Follow-up to #2143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.