Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert misc. legacy PDO usages to Laravel DB facade #2268

Merged

Conversation

williamjallen
Copy link
Collaborator

This PR contains miscellaneous changes I've accumulated over time while waiting for the tests to run. This is a small incremental piece of the larger goal of using the Laravel DB facade for all database interactions. Doing so will enable us to accurately log queries being executed, amongst other things.

@williamjallen williamjallen added this to the v3.5 milestone Jun 12, 2024
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief manual exploration didn't turn up any issues and the tests seem to be in fine shape. LGTM!

@williamjallen williamjallen added this pull request to the merge queue Jun 17, 2024
Merged via the queue into Kitware:master with commit ffcd8cb Jun 17, 2024
6 checks passed
@williamjallen williamjallen deleted the legacy-pdo-connection-cleanup branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants