Skip to content

Commit

Permalink
COMP: Fix clang -Wtautological-pointer-compare warnings
Browse files Browse the repository at this point in the history
Warning was:

```
/Modules/Registration/GPUPDEDeformable/include/itkGPUPDEDeformableRegistrationFilter.hxx:102:7: warning: comparison of array 'this->m_GPUSmoothingKernels' not equal to a null pointer is always true [-Wtautological-pointer-compare]
  if (m_GPUSmoothingKernels != nullptr)
      ^~~~~~~~~~~~~~~~~~~~~    ~~~~~~~
```

Indeed these can never be null.
  • Loading branch information
seanm authored and N-Dekker committed Aug 30, 2024
1 parent 9eb1359 commit 923ee4e
Showing 1 changed file with 8 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,15 @@ GPUPDEDeformableRegistrationFilter<TFixedImage, TMovingImage, TDisplacementField
}

os << indent << "SmoothingKernels: ";
if (m_SmoothingKernels != nullptr)
for (unsigned d = 0; d < ImageDimension; ++d)
{
for (unsigned d = 0; d < ImageDimension; ++d)
{
os << indent.GetNextIndent() << m_SmoothingKernels[d] << std::endl;
}
os << indent.GetNextIndent() << m_SmoothingKernels[d] << std::endl;
}

os << indent << "GPUSmoothingKernels: ";
if (m_GPUSmoothingKernels != nullptr)
for (unsigned d = 0; d < ImageDimension; ++d)
{
for (unsigned d = 0; d < ImageDimension; ++d)
{
os << indent.GetNextIndent() << m_GPUSmoothingKernels[d] << std::endl;
}
os << indent.GetNextIndent() << m_GPUSmoothingKernels[d] << std::endl;
}

os << indent << "UpdateFieldSmoothingKernelSizes: ";
Expand All @@ -114,21 +108,15 @@ GPUPDEDeformableRegistrationFilter<TFixedImage, TMovingImage, TDisplacementField
}

os << indent << "UpdateFieldSmoothingKernels: ";
if (m_UpdateFieldSmoothingKernels != nullptr)
for (unsigned d = 0; d < ImageDimension; ++d)
{
for (unsigned d = 0; d < ImageDimension; ++d)
{
os << indent.GetNextIndent() << m_UpdateFieldSmoothingKernels[d] << std::endl;
}
os << indent.GetNextIndent() << m_UpdateFieldSmoothingKernels[d] << std::endl;
}

os << indent << "UpdateFieldGPUSmoothingKernels: ";
if (m_UpdateFieldGPUSmoothingKernels != nullptr)
for (unsigned d = 0; d < ImageDimension; ++d)
{
for (unsigned d = 0; d < ImageDimension; ++d)
{
os << indent.GetNextIndent() << m_UpdateFieldGPUSmoothingKernels[d] << std::endl;
}
os << indent.GetNextIndent() << m_UpdateFieldGPUSmoothingKernels[d] << std::endl;
}

os << indent << "ImageSizes: ";
Expand Down

0 comments on commit 923ee4e

Please sign in to comment.