Skip to content

Commit

Permalink
remove legacy method signature for multitexture
Browse files Browse the repository at this point in the history
Marking one signature of a method as legacy when it
is overridden is a mess as it results in either a
partial override or a deprecated override method both
of which result in a warning so just removing that sig.
The method has been a nop for a few releases.
  • Loading branch information
martinken committed Feb 25, 2018
1 parent f21d1c1 commit 2f231fb
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 34 deletions.
12 changes: 0 additions & 12 deletions Rendering/Core/vtkPolyDataMapper.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -183,18 +183,6 @@ void vtkPolyDataMapper::MapDataArrayToVertexAttribute(
vtkErrorMacro("Not implemented at this level...");
}

#ifndef VTK_LEGACY_REMOVE
void vtkPolyDataMapper::MapDataArrayToMultiTextureAttribute(
int vtkNotUsed(unit),
const char* vtkNotUsed(dataArrayName),
int vtkNotUsed(fieldAssociation),
int vtkNotUsed(componentno)
)
{
VTK_LEGACY_BODY(vtkPolyDataMapper::MapDataArrayToMultiTextureAttribute, "VTK 8.2");
}
#endif

//----------------------------------------------------------------------------
void vtkPolyDataMapper::MapDataArrayToMultiTextureAttribute(
const char* vtkNotUsed(tname),
Expand Down
5 changes: 0 additions & 5 deletions Rendering/Core/vtkPolyDataMapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,6 @@ class VTKRENDERINGCORE_EXPORT vtkPolyDataMapper : public vtkMapper
const char *textureName,
const char* dataArrayName, int fieldAssociation, int componentno = -1);

// deprecated in favor of the const char * signature
VTK_LEGACY(virtual void MapDataArrayToMultiTextureAttribute(
int unit,
const char* dataArrayName, int fieldAssociation, int componentno = -1));

/**
* Remove a vertex attribute mapping.
*/
Expand Down
12 changes: 0 additions & 12 deletions Rendering/OpenGL2/vtkOpenGLPolyDataMapper.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -3572,18 +3572,6 @@ void vtkOpenGLPolyDataMapper::MapDataArrayToMultiTextureAttribute(
dataArrayName, tname, fieldAssociation, componentno);
}

#ifndef VTK_LEGACY_REMOVE
void vtkOpenGLPolyDataMapper::MapDataArrayToMultiTextureAttribute(
int vtkNotUsed(unit),
const char* vtkNotUsed(dataArrayName),
int vtkNotUsed(fieldAssociation),
int vtkNotUsed(componentno)
)
{
VTK_LEGACY_BODY(vtkPolyDataMapper::MapDataArrayToMultiTextureAttribute, "VTK 8.2");
}
#endif

void vtkOpenGLPolyDataMapper::MapDataArray(
const char* vertexAttributeName,
const char* dataArrayName,
Expand Down
5 changes: 0 additions & 5 deletions Rendering/OpenGL2/vtkOpenGLPolyDataMapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,6 @@ class VTKRENDERINGOPENGL2_EXPORT vtkOpenGLPolyDataMapper : public vtkPolyDataMap
const char *tname,
const char* dataArrayName, int fieldAssociation, int componentno = -1) override;

// deprecated in favor of the const char * signature
VTK_LEGACY(void MapDataArrayToMultiTextureAttribute(
int unit,
const char* dataArrayName, int fieldAssociation, int componentno = -1) override);

/**
* Remove a vertex attribute mapping.
*/
Expand Down

3 comments on commit 2f231fb

@jasjuang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the removal of MapDataArrayToMultiTextureAttribute breaks the compilation for PCL, could you let us know what is the correct way to use newer function to replicate this feature?

The problem occurs at https://github.com/PointCloudLibrary/pcl/blob/master/visualization/src/pcl_visualizer.cpp#L3554

@martinken
Copy link
Member Author

@martinken martinken commented on 2f231fb Apr 30, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasjuang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinken Appreciate your answer!

Please sign in to comment.