Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve setuptools issue #1100

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Resolve setuptools issue #1100

merged 1 commit into from
Dec 28, 2021

Conversation

Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Approving, despite also leaving a suggestion.

@@ -81,5 +81,5 @@ rabbit_user_queues = "rabbitmq_user_queues:GirderPlugin"
dive_tasks = "dive_tasks:DIVEPlugin"

[build-system]
requires = ["poetry-core>=1.0.0"]
requires = ["poetry-core>=1.0.0", "setuptools"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to specify a compatible version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All future versions of setuptools should be compatible. I don't know how I'd restrict this version, because I don't want to use an outdated version or prevent upgrade in the future.

@subdavis subdavis merged commit 35a3b61 into main Dec 28, 2021
@subdavis subdavis deleted the fix-setuptools branch December 28, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants