Don't create extra symlinks to libraries. The soversion property is enough #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=397 |
|
Windows build succeeded: https://open.cdash.org/buildSummary.php?buildid=5022798 |
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5023012 |
mleotta
reviewed
Aug 18, 2017
dstoup
force-pushed
the
libpng-symlink-error
branch
from
55f4608 to
56f2589
Compare
|
Closing and reopening against release |
|
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5030060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes one of the two issues mentioned in issue #178.
There is a macro getting called which makes symlinks. When called on the libraries, it creates too many levels of symlink. It should not be needed anyway since we set_target_properties for the soversion, so the sylinks exists anyway.
The question I have is, should this PR go to master or release? Since it's a bugfix, I am inclined to target release. We can discuss and I will update release-notes once I know which one to edit. Also, I did take the branch from master, so if release is desired, I will need to rebase or cherry-pick.