Add ability to read fields into std::optional #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-riehm
force-pushed
the
dev/csv-input-optional
branch
from
570b90d to
087a2bc
Compare
chetnieter
approved these changes
May 19, 2023
daniel-riehm
force-pushed
the
dev/csv-input-optional
branch
from
087a2bc to
3bfea14
Compare
daniel-riehm
force-pushed
the
dev/csv-input-optional
branch
from
3bfea14 to
c1db7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
csv_reader.read()interface forstd::optionalwrappers around supported field types. This provides an alternate way of handling missing or invalid fields, rather than needing atry{} catch(parse_error){}around every read command.