Add ffmpeg_video_input_clip #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-riehm
force-pushed
the
dev/ffmpeg-clip
branch
2 times, most recently
from
de58bed
to
2bd93f0
Compare
chetnieter
approved these changes
Dec 5, 2023
daniel-riehm
force-pushed
the
dev/ffmpeg-clip
branch
from
2bd93f0
to
68badee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ffmpeg_video_input_clipclass, which is a wrapper around a regularffmpeg_video_inputthat takes in a frame range in its config, and attempts to behave exactly as if the input video consisted only of that frame range. There is also an option to automatically seek back to the most recent keyframe, to avoid the first few frames being undecodable when copying the raw video stream. Accomplishing this required some significant work to be done on the seeking logic offfmpeg_video_input.