Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Specify Gaia explicitly from github. #499

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Specify Gaia explicitly from github. #499

merged 3 commits into from
Apr 17, 2018

Conversation

manthey
Copy link
Member

@manthey manthey commented Mar 30, 2018

Update how setup.py parses requirements.txt.

Update how setup.py parses requirements.txt.
@aashish24 aashish24 self-requested a review April 10, 2018 18:37
aashish24
aashish24 previously approved these changes Apr 13, 2018
Pip isn't allowed to be imported.
matthewma7
matthewma7 previously approved these changes Apr 17, 2018
@manthey
Copy link
Member Author

manthey commented Apr 17, 2018

It would be better not to use dependency links since pip says they are deprecated (see pypa/pip#4187), but I'm not sure if there is an alternative (direct urls might work, but when I try adding gaia@<giit hub url>, I get a Direct url requirement are not allowed for dependencies error from pip 10).

Copy link

@matthewma7 matthewma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manthey manthey merged commit 726e0f2 into master Apr 17, 2018
@manthey manthey deleted the add-requirements branch April 17, 2018 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants