Add mechanism to automatically generate transform parameters UI #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesgenova
force-pushed
the
transform_parameters
branch
2 times, most recently
from
12a9cd3 to
c24fe11
Compare
alesgenova
force-pushed
the
transform_parameters
branch
from
c24fe11 to
cc23c55
Compare
brianhhu
reviewed
Jan 8, 2024
| return self._perturber.perturb(input) | ||
|
|
||
|
|
||
| class NrtkPybsmTransform(ImageTransform): |
There was a problem hiding this comment.
I remember you mentioned a few weeks ago some nuances with the NRTK pyBSM transform code path- please let me know if you run into any blockers when experimenting with an initial implementation. Thanks!
|
This PR looks reasonable to me, I am not as deep into the code as @vicentebolea but the design seems good from a high-level perspective. Thanks! |
brianhhu
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.