Combine original and transformed scatter plots into a single plot #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesgenova
force-pushed
the
scatter-plot-improvements
branch
from
6c17bae to
125edf5
Compare
vicentebolea
requested changes
Feb 14, 2024
| @@ -0,0 +1,37 @@ | |||
| import type { Vector3, Vector4 } from '../types' | |||
There was a problem hiding this comment.
Couple of warnings here.
| name="UMAP", | ||
| fit_features=self.features, | ||
| features=transformation_features, | ||
| dims=self.state.dimensionality, | ||
| ) | ||
|
|
||
| self.state.points_transformations = points_transformations[ | ||
| len(self.state.points_sources or []) : |
There was a problem hiding this comment.
I undertsand this workaround, after merging this I will modify the dimension_reducer class to handle this.
| } | ||
|
|
||
| if (props.selectedPoints.indexOf(i) > -1) { | ||
| return '#bdbdbd' |
There was a problem hiding this comment.
How about returning the toHex(color) rather than the hex.
Comment on lines
+272
to
+273
| const range: Vector2<number> = [0, 1] | ||
| const scale = linearScale(colorMapDomain.value, range) |
There was a problem hiding this comment.
This is repeated at line 44
vicentebolea
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.