Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add obj detect model ui #49

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Mar 18, 2024

  • Added coco Object detection 2017 sample dataset. This is needed since the Object detection model that we use YOLOS was trained with this dataset. For exploratory/demo purposes it dramatically increase inference performance.

  • We compute annotations using a Object detection model for both the source image and transformation.

@vicentebolea vicentebolea force-pushed the run-models branch 8 times, most recently from ad8c3c2 to 42d2fbc Compare March 22, 2024 21:26
@vicentebolea vicentebolea requested a review from alesgenova March 28, 2024 00:43
@vicentebolea vicentebolea marked this pull request as ready for review March 28, 2024 00:50
@vicentebolea vicentebolea force-pushed the run-models branch 2 times, most recently from 9b9ac2c to 079919d Compare March 28, 2024 01:23
Copy link
Member

@alesgenova alesgenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only two minor comments.
Also, sooner rather than later we should settle on a way to have datasets separate from the app repo

src/nrtk_explorer/app/core.py Outdated Show resolved Hide resolved
src/nrtk_explorer/library/object_detector.py Outdated Show resolved Hide resolved
@vicentebolea vicentebolea merged commit 774624e into Kitware:main Apr 5, 2024
5 checks passed
@vicentebolea vicentebolea deleted the run-models branch April 5, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants