Rename and docs update rebase #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkit
approved these changes
Jul 25, 2024
|
@annehaley Can you take a look once more and approve if this looks okay? |
annehaley
reviewed
Jul 26, 2024
pyproject.toml
Outdated
Comment on lines
51
to
66
| all = [ | ||
| # viewer | ||
| "trame>=3.6", | ||
| "trame-vtk>=2.6", | ||
| "trame-vuetify>=2.4", | ||
| "geovista>=0.4", | ||
|
|
||
| # esgf | ||
| "intake-esgf>=2024.1", | ||
|
|
||
| # pangeo | ||
| "intake==0.7.0", # latest has plugin errors | ||
| "intake-xarray>=0.7", | ||
| "intake-esm>=2023.11", | ||
| "s3fs>=2024.2", | ||
| "gcsfs>=2024.2", |
There was a problem hiding this comment.
I think this change is outdated, so you can take this out. I believe @johnkit had mentioned that the recursive dependency definition doesn't work in some cases, so we should use the explicit list.
ayenpure
force-pushed
the
rename-and-docs-update-rebase
branch
from
c8bf5f8
to
321f9bb
Compare
…drawer changes state
ayenpure
force-pushed
the
rename-and-docs-update-rebase
branch
from
321f9bb
to
cdf7e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of MR #83
It contains the changes for renaming
pan3D-viewertogeotrameand updating documentation wherever necessaryI created the MR from a new branch so that we do not lose Anne's branch in case I messed up the rebase.