Merge pull request #414 from Kitware/fix-query-datamodel-destroy

fix(QueryDataModel): Fix destroy method
Kitware · Jan 2, 2018 · ed43866 · ed43866
2 parents 09a2010 + f220288
commit ed43866
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -21,6 +21,7 @@ module.exports = {
     'react/no-unused-prop-types': 0,
 
     // Not for us ;-)
+    'no-plusplus': 0,
     'jsx-a11y/label-has-for': 0,
     'no-console': 0,
     'import/no-named-as-default-member': 0,

diff --git a/src/IO/Core/QueryDataModel/index.js b/src/IO/Core/QueryDataModel/index.js
@@ -83,6 +83,7 @@ export default class QueryDataModel {
     this.mouseListener = null;
     this.dataMetadata = {};
     this.lazyFetchRequest = null;
+    this.registeredURLs = [];
 
     this.playNext = () => {
       if (this.keepAnimating) {
@@ -224,6 +225,7 @@ export default class QueryDataModel {
 
       // Register data handler + listener
       dataManager.registerURL(dataId, (dataEntry.absolute ? '' : basepath) + dataEntry.pattern, dataEntry.type, dataEntry.mimeType);
+      this.registeredURLs.push(dataId);
       dataManager.on(dataId, dataHandler);
       this.dataCount[dataId] = 0;
     });
@@ -637,10 +639,15 @@ export default class QueryDataModel {
   }
 
   destroy() {
-    this.off();
-
     this.explorationSubscription.unsubscribe();
     this.explorationSubscription = null;
+
+    // Remove links to dataManager
+    while (this.registeredURLs.length) {
+      dataManager.unregisterURL(this.registeredURLs.pop());
+    }
+
+    this.off();
   }
 
   // Data exploration -----------------------------------------------------------

diff --git a/src/IO/Core/QueryDataModel/tests/testQueryDataModel.js b/src/IO/Core/QueryDataModel/tests/testQueryDataModel.js
@@ -4,7 +4,7 @@ import QueryDataModel from '..';
 
 // ----------------------------------------------------------------------------
 
-test('Query Data Model - Fetch/Notification', t => {
+test('Query Data Model - Fetch/Notification', (t) => {
   const dataDescription = {
     type: ['tonic-query-data-model', 'slice-prober'],
     arguments: {
@@ -59,12 +59,15 @@ test('Query Data Model - Fetch/Notification', t => {
   let notificationCount = 0;
 
   queryDataModel.onDataChange((data, envelope) => {
-    notificationCount++;
+    notificationCount += 1;
     t.ok(data && !data.error, `callback ${notificationCount}`);
 
     // Finish test
     if (numberOfRequests === notificationCount) {
       // console.log('Fetch/Notification: done with success');
+      // Make sure we can destroy the queryDataModel
+      queryDataModel.destroy();
+      t.ok(true, 'QueryDataModel deleted');
       t.end();
     }
   });
@@ -73,15 +76,15 @@ test('Query Data Model - Fetch/Notification', t => {
 
   let count = numberOfRequests;
   while (count--) {
-    fetchCount++;
+    fetchCount += 1;
     t.comment(`fetch ${fetchCount}`);
     queryDataModel.fetchData();
   }
 });
 
 // ----------------------------------------------------------------------------
 
-test('Query Data Model - API/Query/Validation', t => {
+test('Query Data Model - API/Query/Validation', (t) => {
   const dataDescription = {
     type: ['tonic-query-data-model'],
     arguments: {