fix(ImageCroppingRegionsWidget): Code cleanup

Kitware · Jan 10, 2018 · 920c72a · 920c72a
1 parent 00fb4b7
commit 920c72a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Sources/Interaction/Widgets/ImageCroppingRegionsWidget/example/index.js b/Sources/Interaction/Widgets/ImageCroppingRegionsWidget/example/index.js
@@ -69,7 +69,6 @@ function setupControlPanel(data, imageMapper) {
       .map((v, idx) => (idx === sliceMode ? v + 1 : v));
     const viewUp = [0, 0, 0];
     viewUp[(sliceMode + 2) % 3] = 1;
-    console.log(viewUp);
     renderer.getActiveCamera().set({ position: camPosition, viewUp });
     renderer.resetCamera();
 
@@ -82,17 +81,21 @@ function setupControlPanel(data, imageMapper) {
 // ----------------------------------------------------------------------------
 const widget = vtkImageCroppingRegionsWidget.newInstance();
 widget.setInteractor(renderWindow.getInteractor());
+
+// Demonstrate cropping planes event update
 widget.onCroppingPlanesPositionChanged(() => {
   console.log('planes changed:', widget.getWidgetRep().getPlanePositions());
 });
 
 // called when the volume is loaded
 function setupWidget(volumeMapper, imageMapper) {
   widget.setVolumeMapper(volumeMapper);
-  widget.setEnable(true);
   widget.setHandleSize(10); // in pixels
+  widget.setEnable(true);
 
   // getWidgetRep() returns a widget AFTER setEnable(true).
+
+  // Demonstrate widget representation APIs
   widget.getWidgetRep().setOpacity(0.8);
   widget.getWidgetRep().setEdgeColor(0.0, 0.0, 1.0);
 
@@ -138,7 +141,7 @@ reader
 
     const sliceNormal = ['X', 'Y', 'Z'][sliceMode];
     imageMapper.setCurrentSlicingMode(sliceMode);
-    imageMapper[`set${sliceNormal}Slice`](30);
+    imageMapper[`set${sliceNormal}Slice`](0);
 
     const camPosition = renderer
       .getActiveCamera()

diff --git a/Sources/Interaction/Widgets/ImageCroppingRegionsWidget/index.js b/Sources/Interaction/Widgets/ImageCroppingRegionsWidget/index.js
@@ -197,7 +197,6 @@ function vtkImageCroppingRegionsWidget(publicAPI, model) {
     // Assume we should use the first view
     const view = model.interactor.getView();
     const camUp = model.currentRenderer.getActiveCamera().getViewUp();
-    // TODO verify camUp is axis-aligned
 
     let ax1;
     let ax2;