[Bug] ContourLoopExtraction doesn't work anymore

[daker]

Bug description

Open https://kitware.github.io/vtk-js/examples/ContourLoopExtraction/index.html
Use the example

Uncaught TypeError: Cannot read properties of null (reading 'forEach')
    at e.buildLinks (ContourLoopExtraction.js:1:175374)
    at e.buildLinks (ContourLoopExtraction.js:1:204265)
    at DT (ContourLoopExtraction.js:1:712029)

Steps to reproduce

Check description

Detailed Behavior

Check description

Expected Behavior

Example should work as expected

Environment

• vtk.js version:
• Browsers:
• OS:

[daker]

@finetjul i might think that PR #3319 is causing this issue.
v34.11.0 works v34.11.1 doesn't work

[daker]

The issue starts with cd6b02b exactly this line, reverting this change or adjusting the code to the following makes the example works again:

Patch for vtkContourLoopExtraction

-    if (!outData[0]) {
-      outData[0] = vtkPolyData.newInstance();
-    }
-    const [output] = outData;
+    const output = outData[0] || vtkPolyData.newInstance();
+    outData[0] = output;

@sedghi what do you think ? do you see any impact ?

[sedghi]

maybe we should check if the outData exist first to get the [0]?

[daker]

You mean like the following :

if (!outData[0]) {
    outData[0] = outData[0] || vtkPolyData.newInstance();
}

[sedghi]

I'm not sure if this is just a change to improve code readability with (||) or if it affects the logic. I'll let @finetjul comment on it.

[daker]

After looking at the recent commits 7188a57 i see that the code in vtkContourLoopExtraction evolved and the proposed change will not work.

[github-actions]

🎉 This issue has been resolved in version 34.15.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀