fix(ImageMarchingSquares): use indexToWorld function, rather than separate calculation #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
finetjul
reviewed
Nov 18, 2025
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Please reformat your commit message to match semantic release.
Joeycho
changed the title
Joeycho
changed the title
Joeycho
changed the title
…arate calculation
finetjul
reviewed
Nov 26, 2025
finetjul
reviewed
Dec 1, 2025
| // pixelPts = a flattened world coordinates array of [ (i,j,k), (i+1,j,k), (i,j+1,k), (i+1,j+1,k)] | ||
|
|
||
| // 0: i, j, k | ||
| let worldPos = indexToWorld(ijk); |
Member
There was a problem hiding this comment.
please use the indexToWorld aout parameter for better performance (to avoid instantiating a new array each time)
| pixelPts[2] = worldPos[2]; | ||
|
|
||
| // 1: i+1, j, k | ||
| const ijk1 = [...ijk]; |
Member
There was a problem hiding this comment.
maybe you could do something like the following to avoid instantiating many arrays:
const neighborIJK = [...ijk];
indexToWorld()
neighborIJK[kernelX] += 1;
indexToWorld()
neighborIJK[kernelY] += 1;
indexToWorld()
neighborIJK[kernelX] -= 1;
indexToWorld()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current:
direction missing.
#3355
PR:
Input image has indexToWorld function. Reuse it.