Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full filenames in logs. #226

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Support full filenames in logs. #226

merged 1 commit into from
Oct 11, 2017

Conversation

spinorx
Copy link
Contributor

@spinorx spinorx commented Oct 10, 2017

No description provided.

@KjellKod
Copy link
Owner

@spinorx thanks for the pull request.

Please provide the following

  1. Addition to the Options cmake file. Please make the default for this define as false.
  2. A description for the pull request. For historical reasons a one or two liners - however obvious makes it easier for people when browsing changes.

Cheers
Kjell

@spinorx
Support full filenames in logs.
fd4b751 
This is helpful for doing cut and paste of filenames when opening.
Also fixed couple of macro parentheses.
@spinorx
Copy link
Contributor Author

spinorx commented Oct 11, 2017

Updated. Let me know. Also fixed 2 macros which didn't have parentheses around them.

@KjellKod
Copy link
Owner

👍

@KjellKod
Copy link
Owner

Thanks for the contribution

@KjellKod KjellKod merged commit 28105e0 into KjellKod:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spinorx @KjellKod