add option to disable installing g3sinks for projects embedding #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is modeled off the work done in KjellKod/g3log#333 Signed-off-by: Ben Magistro <koncept1@gmail.com>
bmagistro
force-pushed
the
optional-install
branch
from
0a75d74 to
b486c7c
Compare
|
@bmagistro this works great, can you pull in the latest changes from master, and fix the conflict in the PR and push an update? |
KjellKod
approved these changes
Jan 12, 2023
|
@bmagistro never mind, github took care of it and it wasn't a conflict after all. |
|
thanks for adding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is modeled off the work done in KjellKod/g3log#333
Signed-off-by: Ben Magistro koncept1@gmail.com
I've been using this with logrotate but have not tested with the other sinks, do not anticipate any issues