Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake to download GoogleTest as part of build #94

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Use CMake to download GoogleTest as part of build #94

merged 2 commits into from
Jun 7, 2020

Conversation

mkilivan
Copy link
Contributor

@mkilivan mkilivan commented Jun 2, 2020

This change is to use CMake to download GoogleTest as part of the
build's configuration step.

@mkilivan
Copy link
Contributor Author

mkilivan commented Jun 2, 2020

Please note that KjellKod/g3log#355 should be merged before this pull request. This is why CI build failed.

GoogleTest is now available on the top level. So, it will be downloaded and used for once for all sub folders.

ADD_LOGROTATE_UNIT_TEST CMake option has been renamed to BUILD_TEST. And moved to top level.

@KjellKod
Copy link
Owner

KjellKod commented Jun 3, 2020

This is a sweet change @mkilivan
KjellKod/g3log#355 is now merged. When you have time, please update this PR accordingly.

This change is to use CMake to download GoogleTest as part of the
build's configuration step.
Copy link
Owner

@KjellKod KjellKod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason g3sinks notification did not reach me. Github's notification to me is still wonky :(

Not sure what's going on here with this PR but if I run this :

cd build; cmake -BUILD_TEST=ON ..

It creates a directory "UILD_TEST" and puts all build artifacts in there.

If I simply run

```cd build; cmake ..

Then all artifacts are, as expected in the build directory

@KjellKod
Copy link
Owner

KjellKod commented Jun 7, 2020

Ooops. Never mind I built it poorly I forgot the D in cmake -DBUILD_TEST=ON ..

Copy link
Owner

@KjellKod KjellKod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! thanks for the improvement

@KjellKod KjellKod merged commit bf6fa91 into KjellKod:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants