Add missing deployment scripts and doc improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dakavon
reviewed
Jan 22, 2022
| @@ -74,7 +74,7 @@ module.exports = { | |||
| initialBaseFeePerGas: 0, // workaround from https://github.com/sc-forks/solidity-coverage/issues/652#issuecomment-896330136 . Remove when that issue is closed. | |||
| }, | |||
| ropsten: { | |||
| url: process.env.ROPSTEN_URL || "", | |||
| url: "https://ropsten.infura.io/v3/f16fe897786f47149695118b395db6e3", | |||
There was a problem hiding this comment.
process.env.ROPSTEN_URL was correct, no? 🙈
There was a problem hiding this comment.
Heh, just aligning with the rest of the networks in the config.
|
Looks pretty neat, would love to see this PR merged. |
|
@ArchimedesCrypto @0xAurelius @cujowolf can anyone please have a look here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested these scripts in Ropsten successfully.
Planning to add scripts for bonds and the DAO in a follow-up PR, if this one gets merged.