Add redis caching #587
Merged
Add redis caching #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenheart
requested changes
Jan 27, 2025
src/api/schemas/response.ts
Outdated
| .openapi({ description: 'Start date of reporting period' }), | ||
| endDate: z.date().openapi({ description: 'End date of reporting period' }), | ||
| endDate: z | ||
| .union([z.date(), z.string()]) |
There was a problem hiding this comment.
Same thing here with the z.string().date()
Greenheart
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Redis Caching
🌍 This PR introduces Redis-based caching for better performance and reduced database load.
Key Updates:
🌍 Companies API:
- Implements Redis cache with dynamic keys tied to latestMetadataUpdatedAt.
- Reduces redundant database queries by serving cached data when available.
🌍 Municipalities API:
- Adds Redis cache with a static key since data is immutable.
- Enhances performance with faster responses for repeated requests.
Benefits:
🌍 Optimized server performance.
🌍 Simplified cache management with automatic invalidation for updates.
🌍 Scalable design leveraging Redis.
🏠 Updated the readme with a quick setup for redis insight. Where you can inspect you redis data
Testing:
✅ Verified caching works for /companies and /municipalities APIs.
✅ Ensured no impact on existing ETag implementation.