Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation anchors not working on Safari, macOS and iOS #4538

Closed
blalor opened this issue Jul 28, 2021 · 3 comments
Closed

Documentation anchors not working on Safari, macOS and iOS #4538

blalor opened this issue Jul 28, 2021 · 3 comments
Labels
resolved Issue is thought to now be fixed

Comments

@blalor
Copy link

blalor commented Jul 28, 2021

After the (fantastic) site update #4512, anchors aren't working correctly when loading the page on Safari on iOS (14.7) and macOS (11.4, Safari 14.1.1). For example, if I open https://www.klipper3d.org/Config_Reference.html#heater_bed in a new tab, the page doesn't scroll to the anchor, but if I click it from the nav on the right, it does. Firefox 89.0.2 does not show this behavior. This means that linking between sections on different pages doesn't work.
@damlobster
Copy link
Contributor

Thanks @blalor for spotting this, I'll look into how to solve it.

damlobster added a commit to damlobster/klipper that referenced this issue Jul 28, 2021
@damlobster
klipper3d: links to anchors not working with Safari
56a48f2 
Solves issue Klipper3d#4538

Signed-off-by: Damien Martin <damlobster@gmail.com>
@damlobster damlobster mentioned this issue Jul 28, 2021
Merged
KevinOConnor pushed a commit that referenced this issue Jul 28, 2021
@damlobster @KevinOConnor
klipper3d: links to anchors not working with Safari
be12241 
Solves issue #4538

Signed-off-by: Damien Martin <damlobster@gmail.com>
@KevinOConnor
Copy link
Collaborator

Thanks. Hopefully this is resolved with the merge of #4539 .

-Kevin

@KevinOConnor KevinOConnor added the resolved Issue is thought to now be fixed label Jul 28, 2021
@blalor
Copy link
Author

blalor commented Jul 28, 2021

It is! Thank you!

@blalor blalor closed this as completed Jul 28, 2021
Cirromulus pushed a commit to Cirromulus/klipper that referenced this issue Aug 4, 2021
@damlobster @Cirromulus
klipper3d: links to anchors not working with Safari
abb1864 
Solves issue Klipper3d#4538

Signed-off-by: Damien Martin <damlobster@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
resolved Issue is thought to now be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blalor @KevinOConnor @damlobster