Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAN: Kick start fan when the increase is more than 50% #2085

Merged
merged 1 commit into from
Nov 24, 2019
Merged

FAN: Kick start fan when the increase is more than 50% #2085

merged 1 commit into from
Nov 24, 2019

Conversation

jschuh
Copy link
Contributor

@jschuh jschuh commented Oct 19, 2019

Large increases in fan speed can suffer from acceleration lag, so this
change kick starts the fan for a change of 50% or more in the same way
that starting the fan from 0% does.

Signed-off-by: Justin Schuh code@justinschuh.com

Large increases in fan speed can suffer from acceleration lag, so this
change kick starts the fan for a change of 50% or more in the same way
that starting the fan from 0% does.

Signed-off-by: Justin Schuh <code@justinschuh.com>
@KevinOConnor
Copy link
Collaborator

Thanks. In general it looks fine to me. Could you elaborate on the "acceleration lag"? What are the adverse effects a user experiences when fan acceleration lag occurs?

-Kevin

@jschuh
Copy link
Contributor Author

jschuh commented Oct 23, 2019

I would describe the artifact as a more pronounced seam on the print. That stated, I really only encounter it when using this patch I wrote for Prusa Slicer. The scenario is using a very low fan speed for interior perimeters and infill (e.g. 10%), combined with a higher fan speed for the exterior perimeters (e.g. 70%). There's a range where the fan doesn't seem to spin up fast enough as it starts the outer perimeter. I noticed that I didn't see this artifact when the fan switched from being off entirely, so I made this change and it appeared to resolve the problem I was seeing.

Not too scientific, I know, but I figured I'd post the patch and see if it was useful for anyone else.

@JohnEdwa
Copy link

The master build of Cura also has a similar "Infill fan speed" option, and I'd suspect it'll eventually make its way to the main build too, as it's been shown to increase layer adhesion and part strength.
I've noticed the same issue and something like this would help get the fan going faster.

@KevinOConnor KevinOConnor merged commit 93f1e6d into Klipper3d:master Nov 24, 2019
@KevinOConnor
Copy link
Collaborator

Makes sense. Thanks.

-Kevin

Athemis pushed a commit to Athemis/klipper that referenced this pull request Dec 1, 2019
Large increases in fan speed can suffer from acceleration lag, so this
change kick starts the fan for a change of 50% or more in the same way
that starting the fan from 0% does.

Signed-off-by: Justin Schuh <code@justinschuh.com>
dmbutyugin pushed a commit to dmbutyugin/klipper that referenced this pull request Jan 6, 2020
Large increases in fan speed can suffer from acceleration lag, so this
change kick starts the fan for a change of 50% or more in the same way
that starting the fan from 0% does.

Signed-off-by: Justin Schuh <code@justinschuh.com>
FHeilmann pushed a commit to FHeilmann/klipper that referenced this pull request Jan 28, 2020
Large increases in fan speed can suffer from acceleration lag, so this
change kick starts the fan for a change of 50% or more in the same way
that starting the fan from 0% does.

Signed-off-by: Justin Schuh <code@justinschuh.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants