-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building for "Linux Process" in non-FHS environments #6493
Conversation
Thanks, I just looked into setting up the host MCU and ran into this issue. This PR fixed compilation for me :) |
Glad it helped, are you also running on NixOS by chance? I'm also putting some TLC into the nixpkg module. |
Yes, I am. Feel free to ping me on matrix (@CRTified:crtified.me), I got the host mcu working on NixOS already :) |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Discord Link to a discussion about this. |
Thanks. It seems fine to me. Could you split the line in the Makefile so it does not exceed 80 characters though? -Kevin |
The -iquote tells GCC to only search that path when resolving a quoted "include" (vs <angle brackets>) which by convention imples a include from the projects own soruce tree. This prevents a conflict between Klippers "sched.h" and "gpio.h" and <linux/gpio.h> and glibc <sched.h>. Signed-off-by: Michael 'ASAP' Weinrich <michael@a5ap.net>
Not all systems (i.e. Nix) repect the standard Linux filesystem hierarchy, instead relative paths should be used and allowing GCC to rely on it's builtin search paths. Signed-off-by: Michael 'ASAP' Weinrich <michael@a5ap.net>
Thanks! Makefile corrected for the non-ultrawide proletariat. |
Thanks. -Kevin |
This PR addresses building the Klipper "Linux Process" MCU on filesystem layouts that don't adhere to the FHS standard (i.e. NixOS) . It replaces the absolute include paths in
main.c
andgpio.c
with relative paths. It also adjusts CFLAGS to use-iquote
to prevent conflicts when resolving quoted "includes" and .The finest of "builds for me" testing was carried out successfully.