-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add warning about new-stock ender 3s #6730
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
Signed-off-by: Luke Schwager <luke@blucobalt.dev>
Should be good now. |
Thanks, looks fine to me as an informational, as this is indeed the case. The other option would be to create a whole new file referencing the date these started shipping without the melzi boards, but I think that could get confusing. @KevinOConnor what do you think? Thanks |
Actually, that might make more sense. A little bit of research says that this hardware change happened in July of 2020. Let me make that new config. |
…to their own config Signed-off-by: Luke Schwager <luke@blucobalt.dev>
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
My Ender 3 (bought in 2021?) came with a 4.2.2 board out of the box. I just want to add this note to hopefully help someone else, because I lost a good couple of hours trying to figure this out ;)