Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use transport parameter in httpx.AsyncClient #17

Merged
merged 1 commit into from
May 2, 2024

Conversation

TheoBabilon
Copy link
Contributor

@TheoBabilon TheoBabilon commented May 2, 2024

Fixes #16

Note that it currently makes pyright unhappy with

 Argument of type "FastAPI" cannot be assigned to parameter "app" of type "_ASGIApp" in function "__init__"

but I believe this will be fixed when encode/httpx#3109 is released, so I'm not adding any # type: ignore for the sake of simplicity.

Also wondering if fastapi docs itself should be updated https://fastapi.tiangolo.com/advanced/async-tests/#example

@Kludex Kludex changed the title Use transport parameter in httpx.AsyncClient 🐛 Use transport parameter in httpx.AsyncClient May 2, 2024
@Kludex
Copy link
Owner

Kludex commented May 2, 2024

Thanks! 👍

@Kludex Kludex merged commit 1fe8c09 into Kludex:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncClient app parameter deprecation
2 participants