ALB: Fix url-encoded query strings; Fix multi-value headers; Fix multi-value query strings #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ALB double quoting work from jordaneremieff/mangum
…iven" This reverts commit 8e29526.
This was referenced Apr 18, 2021
…ed on whether multi-value headers are enabled
…ws_alb_scope_real`
…s` based on whether multi value headers are enabled
jurasofish
changed the title
…m still waiting to hear back from AWS support about whether this is kosher)
jurasofish
added a commit
to jurasofish/mangum
that referenced
this pull request
May 23, 2021
jordaneremieff
pushed a commit
that referenced
this pull request
Jun 5, 2021
* copy with some slight changes from #179 * move headers conversion from `List[Tuple[bytes, bytes]]` to `List[List[bytes]]` up to where the headers are initially transformed * no longer assert that first case mutated string is lowercase * only pull headers from one of `multiValueHeaders` and `headers`
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* copy with some slight changes from Kludex#179 * move headers conversion from `List[Tuple[bytes, bytes]]` to `List[List[bytes]]` up to where the headers are initially transformed * no longer assert that first case mutated string is lowercase * only pull headers from one of `multiValueHeaders` and `headers`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for #178: modified test now fails when URL-encoded query string is given to ALB.
After discussion I'll see if I can implement a fix in this PR.