perf(queue): send authors only on first request

KnapsackPro · Jul 18, 2023 · 3b871c0 · 3b871c0
1 parent a1e7d4b
commit 3b871c0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/lib/knapsack_pro/client/api/v1/queues.rb b/lib/knapsack_pro/client/api/v1/queues.rb
@@ -17,13 +17,13 @@ def queue(args)
                 :node_index => args.fetch(:node_index),
                 :node_build_id => KnapsackPro::Config::Env.ci_node_build_id,
                 :user_seat => KnapsackPro::Config::Env.masked_user_seat,
-                :build_author => KnapsackPro::RepositoryAdapters::GitAdapter.new.build_author,
-                :commit_authors => KnapsackPro::RepositoryAdapters::GitAdapter.new.commit_authors,
               }
 
               if request_hash[:can_initialize_queue] && !request_hash[:attempt_connect_to_queue]
                 request_hash.merge!({
-                  :test_files => args.fetch(:test_files)
+                  :test_files => args.fetch(:test_files),
+                  :build_author => KnapsackPro::RepositoryAdapters::GitAdapter.new.build_author,
+                  :commit_authors => KnapsackPro::RepositoryAdapters::GitAdapter.new.commit_authors,
                 })
               end
 

diff --git a/spec/knapsack_pro/client/api/v1/queues_spec.rb b/spec/knapsack_pro/client/api/v1/queues_spec.rb
@@ -53,6 +53,16 @@
         ).and_return(action)
         expect(subject).to eq action
       end
+
+      it "sends authors" do
+        action = double
+
+        expect(KnapsackPro::Client::API::Action).to receive(:new).with(
+          hash_including(request_hash: hash_including(:build_author, :commit_authors))
+        ).and_return(action)
+
+        expect(subject).to eq action
+      end
     end
 
     context 'when can_initialize_queue=false and attempt_connect_to_queue=false' do
@@ -67,15 +77,5 @@
         expect(subject).to eq action
       end
     end
-
-    it "sends authors" do
-      action = double
-
-      expect(KnapsackPro::Client::API::Action).to receive(:new).with(
-        hash_including(request_hash: hash_including(:build_author, :commit_authors))
-      ).and_return(action)
-
-      expect(subject).to eq action
-    end
   end
 end