chore: update changelog

KnapsackPro · Jul 7, 2023 · 8837064 · 8837064
1 parent 9e53fde
commit 8837064
Show file tree

Hide file tree

Showing 5 changed files with 247 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Changelog
 
+### 5.2.0
+
+* Send authors to the API
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/208
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.2...v5.2.0
+
 ### 5.1.2
 
 * Fix broken RSpec split by test examples feature when `SPEC_OPTS` is set in Queue Mode. Ignore `SPEC_OPTS` when generating test examples report for slow test files.

diff --git a/lib/knapsack_pro/repository_adapters/git_adapter.rb b/lib/knapsack_pro/repository_adapters/git_adapter.rb
@@ -22,10 +22,14 @@ def authors
           .map do |commits, author|
             { commits: commits.to_i, author: KnapsackPro::MaskString.call(author) }
           end
+      rescue Exception
+        [{ commits: 0, author: "no git <no.git@example.com>" }]
       end
 
       def author
         KnapsackPro::MaskString.call(git_author.strip)
+      rescue Exception
+        "no git <no.git@example.com>"
       end
 
       private

diff --git a/spec/fixtures/vcr_cassettes/api/v1/build_distributions/subset/timeout.yml b/spec/fixtures/vcr_cassettes/api/v1/build_distributions/subset/timeout.yml
diff --git a/spec/fixtures/vcr_cassettes/api/v1/build_subsets/create/timeout.yml b/spec/fixtures/vcr_cassettes/api/v1/build_subsets/create/timeout.yml
diff --git a/spec/knapsack_pro/repository_adapters/git_adapter_spec.rb b/spec/knapsack_pro/repository_adapters/git_adapter_spec.rb
@@ -42,6 +42,16 @@
 
       expect(subject.author).to eq 'Jo** Do* <jo**.do*@ex*****.co*>'
     end
+
+    context "when git_author raises an exception" do
+      it "returns the the no git author" do
+        allow_any_instance_of(KnapsackPro::RepositoryAdapters::GitAdapter).to receive(:git_author).and_raise(Exception)
+
+        subject = KnapsackPro::RepositoryAdapters::GitAdapter.new
+
+        expect(subject.author).to eq 'no git <no.git@example.com>'
+      end
+    end
   end
 
   describe '#authors' do
@@ -62,5 +72,15 @@
         { commits: 3, author: "sh**** <sh***.re***@gm***.co*>" },
       ]
     end
+
+    context "when git_authors raises an exception" do
+      it "returns the the no git author" do
+        allow_any_instance_of(KnapsackPro::RepositoryAdapters::GitAdapter).to receive(:git_authors).and_raise(Exception)
+
+        subject = KnapsackPro::RepositoryAdapters::GitAdapter.new
+
+        expect(subject.authors).to eq [{ commits: 0, author: "no git <no.git@example.com>" }]
+      end
+    end
   end
 end