Increase request retry timebox from 4s to 8s and when Fallback Mode is disabled then retry request 6 times #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o API with too many requests and to give time for API server to autoscale and add additional machines to serve traffic
ArturT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general change
1. when Fallback Mode is enabled (default behavior)
This is the default behavior of knapsack_pro to start running tests in Fallback Mode when 3 times request to API fails.
example when Fallback Mode is enabled
8+16 = 24s wait time - knapsack_pro will try to connect with API within 24s before starting running tests in Fallback Mode
2. when Fallback Mode is disabled
KNAPSACK_PRO_FALLBACK_MODE_ENABLED=falsethen retry the request to Knapsack Pro API for 6 times instead of only 3 times.Here is related info when some users want to disable Fallback Mode: https://github.com/KnapsackPro/knapsack_pro-ruby#required-ci-configuration-if-you-use-retry-single-failed-ci-node-feature-on-your-ci-server-when-knapsack_pro_fixed_queue_splittrue-in-queue-mode-or-knapsack_pro_fixed_test_suite_splittrue-in-regular-mode
Related to PR: #100
example when Fallback Mode is disabled
8+16+24+32+40 = 120s = 2 minutes wait time (6 attempts to make a request to API) - knapsack_pro will try to connect with API within 2 minutes before exiting with failure.