Do not allow to use the RSpec tag option together with the RSpec split by test examples feature in knapsack_pro gem in Regular Mode #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples feature at the same time for Regular Mode as well
…ready tested for ensure_no_tag_option_when_rspec_split_by_test_examples_enabled! method. This test is integration test to verify that args in string format --tag example-value will be translated to cli_args array that is understood by ensure_no_tag_option_when_rspec_split_by_test_examples_enabled! method
…d for Regular Mode
ArturT
commented
Jul 8, 2021
| let(:args) { '--tag example-value' } | ||
|
|
||
| it do | ||
| expect { subject }.to raise_error(/It is not allowed to use the RSpec tag option together with the RSpec split by test examples feature/) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
One general integration test is enough, so I removed below test cases as they are covered for ensure_no_tag_option_when_rspec_split_by_test_examples_enabled! method spec now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why don't allow to use RSpec tag option with RSpec split by test examples feature?
https://knapsackpro.com/faq/question/how-to-split-slow-rspec-test-files-by-test-examples-by-individual-it#warning-dont-use-rspec-tag-option
If you do it and you use at the same time
KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES=truethen--tagoption might not be respected by RSpec due to a bug in the RSpec. RSpec has a higher priority to run test examples likespec/a_spec.rb[1:1]than respect the--tagoption. This can result in running test cases that you didn't intend to run.solution
We raise an exception when the user uses RSpec tag option at the same time with RSpec split by test examples feature to warn him.
related
We already implemented such an exception for Queue Mode in #139