Fix bug when test files have no recorded time execution then they should not be detected as slow test files for RSpec split by test examples feature #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be detected as slow test files
ArturT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug
The bug is related to feature: RSpec split by examples.
When API https://docs.knapsackpro.com/api/v1/#build_distributions_last_get returns build distribution with all test files having time execution 0 seconds then all test files were detected as slow test files in knapsack_pro gem. This leads to loading a lot of test examples in RSpec. RSpec could take a lot of memory and slow down, freeze the CI server for the larger test suite.
solution
When test files have no recorded time execution (time execution is 0 seconds) then they should not be detected as slow test files by RSpec split by examples feature.