Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error message to RspecAdapter#bind #165

Merged
merged 1 commit into from
Mar 3, 2022
Merged

add error message to RspecAdapter#bind #165

merged 1 commit into from
Mar 3, 2022

Conversation

nbr
Copy link
Contributor

@nbr nbr commented Dec 22, 2021

Due to the way the adapter name is inferred in KnapsackPro::Adapters::BaseAdapter, RspecAdapter#bind will not write the bind file to the correct location and the command will fail.

This adds an error message when RspecAdapter#bind is called, rather than silently inheriting the method from RSpecAdapter.

@ArturT ArturT merged commit 747e0c1 into KnapsackPro:master Mar 3, 2022
@ArturT
Copy link
Member

ArturT commented Mar 3, 2022

@nbr Thank you for your contribution. I've released a new knapsack_pro gem version 3.2.0.

@nbr nbr deleted the nb-rspecadapter-error branch March 9, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants