Add an attempt to read from the cache for Regular Mode API #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturT
added a commit
that referenced
this pull request
Nov 23, 2022
This way, we can read the test suite split from the cache, and there is no need to send test_files in the request payload from the knapsack_pro gem for all parallel CI nodes. This allows using Regular Mode with a large test suite (many thousands of test files across hundreds of parallel CI nodes) because requests from parallel CI nodes are fast. There is a limited number of slow requests with a big list of test files in the request payload. #182 Commits: Add an attempt to read from cache for Regular Mode add CI build ID in the Regular Mode request improve language and be more explicit Fix integration specs for Regular Mode and refresh VCR cassettes Update CHANGELOG.md
ArturT
force-pushed
the
regular-mode-improvement
branch
from
88069ed to
854b642
Compare
ArturT
added a commit
that referenced
this pull request
Nov 23, 2022
This way, we can read the test suite split from the cache, and there is no need to send test_files in the request payload from the knapsack_pro gem for all parallel CI nodes. This allows using Regular Mode with a large test suite (many thousands of test files across hundreds of parallel CI nodes) because requests from parallel CI nodes are fast. There is a limited number of slow requests with a big list of test files in the request payload. #182 Commits: Add an attempt to read from cache for Regular Mode add CI build ID in the Regular Mode request improve language and be more explicit Fix integration specs for Regular Mode and refresh VCR cassettes Update CHANGELOG.md
ArturT
force-pushed
the
regular-mode-improvement
branch
from
854b642 to
37818cc
Compare
shadre
requested changes
Nov 25, 2022
This way, we can read the test suite split from the cache, and there is no need to send test_files in the request payload from the knapsack_pro gem for all parallel CI nodes. This allows using Regular Mode with a large test suite (many thousands of test files across hundreds of parallel CI nodes) because requests from parallel CI nodes are fast. There is a limited number of slow requests with a big list of test files in the request payload. #182 Commits: Add an attempt to read from cache for Regular Mode add CI build ID in the Regular Mode request improve language and be more explicit Fix integration specs for Regular Mode and refresh VCR cassettes Update CHANGELOG.md
ArturT
force-pushed
the
regular-mode-improvement
branch
from
37818cc to
92b38c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an attempt to read from the cache for Regular Mode API.
This way, we can read the test suite split from the cache, and there is no need to send
test_filesin the request payload from the knapsack_pro gem for all parallel CI nodes.This allows using Regular Mode with a large test suite (many thousands of test files across hundreds of parallel CI nodes) because requests from parallel CI nodes are fast. There is a limited number of slow requests with a big list of test files in the request payload.
related PRs
related old PR
This PR is inspired by the improvement made for Queue Mode: