Adjust the timer behaviour in the RSpec adapter #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturT
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
It seems to work fine. 👍 I tested it locally with a rails app project by commenting out this line.
You could update the changelog as part of this PR.
Was this also causing some of the test files to have 0 seconds of execution time? I was not sure how to reproduce this edge case. |
It seems plausible but I am not entirely sure about that. |
shadre
force-pushed
the
fix-time-tracking-bug
branch
from
893c8cc to
cf1758c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the timer being stopped in the same test file.
Shout-out to @evanlok for the inspiration and code example