Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask user seats data instead of hashing it #202

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Mask user seats data instead of hashing it #202

merged 1 commit into from
Jun 8, 2023

Conversation

shadre
Copy link
Member

@shadre shadre commented Jun 8, 2023

No description provided.

@shadre shadre added the wip Work in progress label Jun 8, 2023
@shadre shadre requested a review from ArturT June 8, 2023 12:12
@shadre shadre removed the wip Work in progress label Jun 8, 2023
ArturT
ArturT approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ArturT ArturT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please note we hash user seat value again on the API side so we would have to remove hashing on the API side. EDITED: that's not true.

@shadre shadre merged commit f90909f into master Jun 8, 2023
@shadre shadre deleted the mask-user-seats branch June 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturT ArturT ArturT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadre @ArturT