Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true as default value in Queue Mode for GitLab CI #206

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Use KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true as default value in Queue Mode for GitLab CI #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c56e1d
fix: use fixed queue split for gitlab
3v0k4 Jun 19, 2023
9c02fa8
Bump version 5.1.1
3v0k4 Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

### 5.1.1

* Use `KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true` as default value in Queue Mode for GitLab CI

https://github.com/KnapsackPro/knapsack_pro-ruby/pull/206

https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.1.0...v5.1.1

### 5.1.0

* Mask user seats data instead of hashing it
Expand Down
2 changes: 1 addition & 1 deletion lib/knapsack_pro/config/ci/gitlab_ci.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def detected
end

def fixed_queue_split
false
true
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/knapsack_pro/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module KnapsackPro
VERSION = '5.1.0'
VERSION = '5.1.1'
end
2 changes: 1 addition & 1 deletion spec/knapsack_pro/config/env_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@
['Codefresh', { 'CF_BUILD_ID' => '123' }, false],
['Codeship', { 'CI_NAME' => 'codeship' }, true],
['GitHub Actions', { 'GITHUB_ACTIONS' => 'true' }, true],
['GitLab CI', { 'GITLAB_CI' => 'true' }, false],
['GitLab CI', { 'GITLAB_CI' => 'true' }, true],
['Heroku CI', { 'HEROKU_TEST_RUN_ID' => '123' }, false],
['Semaphore CI 1.0', { 'SEMAPHORE_BUILD_NUMBER' => '123' }, false],
['Semaphore CI 2.0', { 'SEMAPHORE' => 'true', 'SEMAPHORE_WORKFLOW_ID' => '123' }, false],
Expand Down