Require rails_helper before configuring RSpec #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacyfik
force-pushed
the
require-rails-helper
branch
2 times, most recently
from
23f00af to
a965543
Compare
ArturT
reviewed
Mar 7, 2024
Pacyfik
force-pushed
the
require-rails-helper
branch
from
d2bebcc to
616cc4a
Compare
ArturT
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Good direction. I added some comments.
We will need integration tests in spec/integration/runners/queue/rspec_runner_spec.rb. We want to cover case when the rails_helper.rb file exists and it has RSpec before(:suite), after(:suite) hooks defined and only a spec file in 2nd batch of tests requires rails_helper.
Pacyfik
force-pushed
the
require-rails-helper
branch
from
616cc4a to
6d507bd
Compare
Pacyfik
force-pushed
the
require-rails-helper
branch
from
ec8e0e8 to
ede4590
Compare
Pacyfik
force-pushed
the
require-rails-helper
branch
from
ede4590 to
10de75b
Compare
Co-Authored-By: Artur Trzop <arturtrzop@gmail.com>
Pacyfik
force-pushed
the
require-rails-helper
branch
from
10de75b to
80e389d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
https://trello.com/c/iyN1GKYS/320-bug-rspec-knapsackpro-700-fails-with-the-dotenv-gem
Related
#242
Description
Version 7.0.0 introduced some fundamental changes, namely fetching, loading and running batches of specs after executing suite hooks, so that such hooks are only ran once, not before every batch. As a result, if
rails_helperis only required in spec files, which is the RSpec default, instead of e.g. in.rspec, then somebefore(:suite)hooks, e.g. defined by gems, are registered after suite hooks had already been executed by the test suite. In comparison, RSpec loads all the spec files before executingbefore(:suite)hooks.Changes
This PR conditionally adds
--require rails_helperto cli arguments ofKnapsackPro::Runners::Queue::RSpecRunnerso that the Rails app (and its gems) can be loaded before executingbefore(:suite)hooks. That way all thebefore(:suite)hooks are registered properly and can be executed.Checklist reminder
lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.