Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSpec] [Queue Mode] Log error message and backtrace when unexpected failure raised in process #249

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

tubaxenor
Copy link
Contributor

Description

Currently when unexpected error raised, we only get the class name from exception.inspect, this PR adds details to the logger to be able to trace or debug the cause.

Changes

Add more logs when unexpected error raised in runner process.

Checklist reminder

  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

@ArturT ArturT added the RSpec label Apr 30, 2024
@ArturT ArturT changed the title Log error message and backtrace when unexpected failure raised in process [RSpec] [Queue Mode] Log error message and backtrace when unexpected failure raised in process Apr 30, 2024
@ArturT ArturT merged commit acf5790 into KnapsackPro:master Apr 30, 2024
45 checks passed
@ArturT
Copy link
Member

ArturT commented Apr 30, 2024

Thank you for the contribution. We've released the knapsack_pro v7.1.0 gem version.

@tubaxenor tubaxenor deleted the xc-enhance-error-output branch April 30, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants