Refactor queue rspec runner

[ArturT]

story

https://trello.com/c/BcBhX2MW

related

• Stop calling RSpec::Core::Runner#run multiple times in Queue Mode knapsack_pro-ruby#237

How to mock the Queue API responses in the knapsack_pro gem

You can add the following code to the source code of the Knapsack Pro gem to mock the Queue API responses.
KnapsackPro/knapsack_pro-ruby@348f563

# lib/knapsack_pro/queue_allocator.rb

    def test_file_paths(can_initialize_queue, executed_test_files)
      if ENV['MOCK_QUEUE_API_RESPONSE'] == 'true'
        @@index ||= 0
        batches = [
          ['spec/features/calculator_spec.rb[1:2:1]', 'spec/controllers/articles_controller_spec.rb'],
          ['spec/collection_spec.rb'],
          ['spec/features/calculator_spec.rb[1:1:1]'],
          ['spec/bar_spec.rb'],
          [], # the last Queue API response is always an empty list of test files
        ]

        # example of an empty batch for a late CI node
        #batches = [
          #[]
        #]
        tests = batches[@@index] || []
        @@index += 1
        puts '='*50
        puts 'Tests (mocked API response):'
        puts tests.inspect
        puts '='*50
        return tests
      end

      return [] if @fallback_activated
...

[ArturT]

The purpose of this file was to help developer (me) to play with the knapsack_pro gem and a Rails app at the same time, so that I could see what will happen on the output, I could use a debugger etc.

We have isolated integration tests in PR KnapsackPro/knapsack_pro-ruby#237
The isolated integration tests are already covering all edge cases (except real API calls).

This bin script is in bin/edge_cases directory. It is not executed as part of bin/knapsack_pro_all bin script (see).

[3v0k4]

I don't have much to say about this, but I hope that going forward we'll wipe this repo 🙂

[ArturT]

I don't have much to say about this, but I hope that going forward we'll wipe this repo 🙂

We are moving in this direction but I think we still need it so that we could easily test a Rails app + Knapsack Pro integration on various CI providers.