Transitioning to Sveltekit #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for the asset tracking page because it's related to the exchange site (Progress of solving issues #2)
From changing from Svelte to Sveltekit, the queryString isn't available method now. Instead, we use shared variable between exchange/+page.svelte and exchange/leftPanel.svelte
So the components don't exceed the screen boundaries anymore 👍
Because Sveltekit is based on server rendering... using browser($app/environment) is encouraged
centerPanel.svelte can be decomposed as headerPanel.svelte, chartPanel.svelte, and orderPanel.svelte. This approach gives more consistent and manageable approaches. Plus, used Svelte store to keep which market the user is watching, to share the same data across all Svelte pages in /exchange endpoint.
string.lower() should contain only lowercase alphabets
Currently this is the best
Delete obsolete version tag. Update node.js 18 to 20.
By using %sveltekit% prefix
Found that meta.js as a separated file didn't work at all :(
Resolving the issue #3 by not allowing negative values in trading, and setting all request schemas to must be positive values
LocalStorage objects are not defined in Sveltekit, which is the server rendering side
The change ensures that the username field accepts only alphanumeric characters and underscores, and displays an error message with a red highlight if the entered username is invalid.
Thank you!
Selectively apply TLS/SSL meta tag according to the env (Refer to the commit #086e27f, which was incorrect of loading a JavaScript file in Sveltekit)
Integrated a script into app.html to dynamically add a Content-Security-Policy meta tag when the current page URL uses HTTPS, enhancing security. Finally found the solution!
Because there was no backend-side filetype validation about profile image uploading, malicious attackers may send invalid file so the website rendering gets broken
Invalid tickers may result invalid transactions, which doesn't make the real money transactions
Yes, other hackers just hopped into my server with a pile of shotguns.
Note that there should be appropriate configuration such like ".env" in <KCX_PROJECT_DIR>/backend/.secrets.smtp
Now, we have a method if the user is really authenticated or not.
Now, if the user has been successfully authenticated its account's ownership by its connected email, the password will be reset!
I added a second password input to confirm the user's password and dynamically check if the passwords match, providing feedback. Additionally, if the user fails to enter the correct verification code, the state resets so they must request the verification code again.
Balance deposite/withdraw, buy/sell crypto should be "positive float", not "non-negative"(which includes zero)
Printing like "-(KRW symbol)100 KRW" is duplicated and unnecessary. Changed the way of printing like "-100 KRW"
With some frontend validation enhancing both UX and UI.
The profile picture upload feature has been updated to properly center the upload icon, display the uploaded file name and size, and ensure the cropper.js object fits within the SweetAlert2 modal.
Setting(changing) profile image has been moved to the user setting page :)
The function name and contents of SMTP were inappropriately designed initially... fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the project has been stabilized after transitioning to Sveltekit from naive and unstructured Svelte, I merge the overall changed on this project to the main branch.