Show errors as 'title'/hover on input fields #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting the input's title attribute)
|
Good stuff - ya, maybe try getting the title attribute off of the element before we execute the If you can do that, I'm glad to merge this in. |
o also maintaining the original title if multiple error messages are applied subsequently
done. |
ericmbarnard
added a commit
that referenced
this pull request
Aug 30, 2012
Show errors as 'title'/hover on input fields
|
Boom - thanks @lcorneliussen ! |
|
Thanks for pulling! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option, implementation and test for showing the errors on hovering the input fields (by setting the input's title attribute)