Support for params to be an observable #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support observable params object i.e. for "min", "max" to be observable. This change just calls unwrapObservable before invoking the validator functions. # Changed test-runner.htm: confirmPassword needs to be required to fire error as both, password and confirmPassword, are initially undefined.
stevegreatrex
added a commit
that referenced
this pull request
Nov 21, 2013
Support for params to be an observable Should also fix #138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to use observables for all validators, i.e. for the min rule. With this pull request the params object is first unwrapped before being passed to the validator method.
Only one test failed: Test 191, the error count in task-runner.htm as password and confirmPassword didn't raise an error. In my opinion this is correct as both values are undefined in the beginning. I added a required rule to confirmPassword to raise the required validation error.