Fix for #368: Breaks on setTextContent call when using minified knockout #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling private (not exported) functions
stevegreatrex
added a commit
that referenced
this pull request
Dec 4, 2013
Fix for #368: Breaks on setTextContent call when using minified knockout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issue #368 and wanted to keep using the non-debug version of knockout in my project.
The change makes the tests run against the production knockout 2.3.0 causing them to fail and then re-greens them by calling public methods.
I wasn't sure if it would be a problem debugging tests using the minified knockout but assume they need to run green against it before release.