Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Search Provider #176

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updated Search Provider #176

wants to merge 5 commits into from

Conversation

ineedfat
Copy link
Contributor

Fixed a view bugs.

Trinh Ho added 5 commits December 13, 2012 18:33
Add search to support cellFilter output
fbcb8c7
Merge branch 'master' of https://github.com/ericmbarnard/KoGrid into …
4dc3061 
…ericmbarnard-master

Conflicts:
	src/classes/searchProvider.js
Fixing few bugs in Search Provider.
154b895 
Remove underlining data filter and only filter visible columns and
visible data (through cellformatter). Add support for edge cases such as
when the column value is an object type.
Removed Uneeded code.
1c9bb10
Add back in the check for destoryed items.
3e30a1c 
Pass value directly into cellFilter and let user handle it, then unwrap
if necessary.
@ineedfat
Copy link
Contributor Author

Oops, must have overlooked that change when merging. I committed the change
and changed a minor thing.

-Trinh

On Wed, Dec 19, 2012 at 2:14 PM, davidjsilva notifications@github.comwrote:

Be careful with "Fixing few bugs in Search Provider" there is a change
that's already been committed into the latest build which is not in your
pull request. Just want to make sure we don't lose that change.

if (searchConditions.length === 0) {
grid.filteredData(grid.sortedData.peek().filter(function(item) {
return !item._destroy;
}));}

Must perform the filter on sortedData in order to hide _destroy'ed rows.

—
Reply to this email directly or view it on GitHubhttps://github.com/ericmbarnard/KoGrid/pull/176#issuecomment-11551262.

Trinh Ho
B.S Computer Science
UW Alumni
Cell: 253-693-8746
tho@cs.washington.edu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ineedfat