-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Features from cwohlman fork #282
Open
cwohlman
wants to merge
68
commits into
Knockout-Contrib:master
Choose a base branch
from
cwohlman:feature/updateKoGridContrib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Features from cwohlman fork #282
cwohlman
wants to merge
68
commits into
Knockout-Contrib:master
from
cwohlman:feature/updateKoGridContrib
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files for compatibility
…s were being imported but not being cleaned to prevent invalid index numbers.
Commits: * Fix a bug in how koGrid shows and hides the lowest level in the grid * Fix a bug in my implementation of show all rows. * Fix to way grid lowest level was expanded - old implementation resulted in only first row being expand/collapsed https://app.asana.com/0/3708490240227/7080763879091
…ows that no longer exist after changing the grouping of the grid.
…ields from parent rows.
it failed to unwrap the groupIndex property of a column
…d selected) state of aggregate rows." This reverts commit 576892d.
… of aggregate rows." Stabilize grid and improve performance of aggregate expand/collapse. This reverts commit 576892d.
… row selection properties after a data refresh.
…based on the collapsed state of their parent aggregate.
…llapsing parent aggregates.
… columns have been ungrouped.
… bug in sortService.js (makes invalid assumptions about grid data, calls string methods on null values)
…use one line changes in our repo)
…ion to return a string (not a toString function), fix pricesheets to ignore empty pricesheet tables (table with empty fld1)
Add a description of changes made in this fork.
Add a link to my ghpages example page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my fork I've added numerous features to the kogrid:
To see the grid in action please see the example page
I'd like to see these features available to everyone else using the kogrid.