When action fails, no log is provided

[marcinus]

Describe the bug
When an operation fails (returns a failed future, or throws without returning), the information about the error is available in the downstream. However, TaskEngine does not log or provide this information in any way.

To Reproduce
Steps to reproduce the behavior:
Create an action that throws an exception or returns a failed failure. Invoke TaskEngine on it.

Expected behavior
The information is available in event log.

Actual behavior
The error information is lost

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
TaskExecutionContext actually logs the error:

    if (isFatal(error)) {
      handleFatalError((NodeFatalException) error);
    } else {
      handleRegularError(error);
    }
    FragmentEvent fragmentEvent = fragmentEventContext.getFragmentEvent();
    return Single.just(new FragmentResult(fragmentEvent.getFragment(), ERROR_TRANSITION,
        prepareErrorActionLog(error)));
  }

  private JsonObject prepareErrorActionLog(Throwable error) {
    return new JsonObject()
        .put("error", error.getMessage());
  }

However, it does not get written to the event log, and node log will not be preserved later (perhaps this is an issue too?)

[tomaszmichalak]

Hi @marcinus, I checked this issue. You are right, this is not valid situation. I am verifying how to combine this data with ActionLog to have a single clear "invocation" syntax.

[tomaszmichalak]

The case: HTTP Action handles an exception and adds errors to the node log (response.log.logs.errors). As you can see response.errors is empty as the fragment operation (HTTP Action) has ended without an exception. @marcinus what do you think?

[marcinus]

@tomaszmichalak Not sure how this relates to the issue? Do you think that HTTP action should propagate exception in this case?
#132 - an issue to control success response codes from HTTP Action