#197 Invoke actions via ActionInvoker #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate exception details in FragmentResult and in invocation logs.
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
+ Coverage 92.07% 92.23% +0.15%
- Complexity 1905 2000 +95
============================================
Files 181 192 +11
Lines 7432 7572 +140
Branches 180 176 -4
============================================
+ Hits 6843 6984 +141
- Misses 502 513 +11
+ Partials 87 75 -12
Continue to review full report at Codecov.
|
Voycawojka
approved these changes
Oct 26, 2020
| @@ -70,6 +77,17 @@ public static FragmentResult fail(Fragment fragment, String errorCode, String er | |||
| FragmentOperationFailure.newInstance(errorCode, errorMessage)); | |||
| } | |||
|
|
|||
| // Should be used only by caller to indicate synchronous or asynchronous exception | |||
There was a problem hiding this comment.
Since this is a comment explaining how the method should be used, maybe it should be a javadoc
| FragmentOperationFailure.newInstance(error)); | ||
| } | ||
|
|
||
| // Should be used only by caller to indicate external timeout |
malaskowski
approved these changes
Oct 26, 2020
| @@ -152,6 +170,19 @@ public FragmentOperationFailure getError() { | |||
| return error; | |||
| } | |||
|
|
|||
| public boolean isSuccess() { | |||
There was a problem hiding this comment.
Either:
isSuccessandisErrorandisException
orisSuccessfulandisErroneousandisExceptional
HTTP Action docs update. Co-authored-by: Marcin <8897707+marcinus@users.noreply.github.com> Co-authored-by: Marcin <8897707+marcinus@users.noreply.github.com>
tomaszmichalak
approved these changes
Oct 27, 2020
| '}'; | ||
| } | ||
|
|
||
| public Status getStatus() { |
There was a problem hiding this comment.
Please move those getters up.
| return error; | ||
| } | ||
|
|
||
| public enum Status { |
There was a problem hiding this comment.
Please move this inner class to the beginnning.
Populate exception details in FragmentResult and in invocation logs.
…otx-fragments into feature/enhance-invocation-logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
ActionInvocationdata object for storing more details about invoking action (duration, errors, cause of completion).Provides
ActionInvokerinterface as a single point of invoking actions, providing race prevention, time measurement and basic error handling (see JavaDoc for details).Introduces additional fields in
ActionInvocationLogin order to pass on information about invoked actions.Motivation and Context
It is a milestone to implement #197. Also, it fixes some potential race issues not tracked directly in Knot.x GitHub.
Upgrade notes (if appropriate)
It is advised to switch from direct action calling to using
ActionInvokerutility class.This ensures that the execution will not halt for some of the known issues in Vert.x and Knot.x implementations.
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.